Add type hints to methods in custom_loggers.py (Fixes #454)#478
Closed
245623733333 wants to merge 3 commits intomllam:mainfrom
Closed
Add type hints to methods in custom_loggers.py (Fixes #454)#478245623733333 wants to merge 3 commits intomllam:mainfrom
245623733333 wants to merge 3 commits intomllam:mainfrom
Conversation
Contributor
|
Hey @245623733333 the particular issue #454 is being solved already in #455 and this is duplicate :). Will be better if you collaborate over there and close this |
Collaborator
|
duplicate and not using PR template at all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added type hints to methods in custom_loggers.py to improve readability, maintainability, and enable better static type checking.
Issue Link
Fixes #454
Type of change
Notes
This change does not modify existing functionality. It only improves type clarity and code quality.