fix: resolve xarray FacetGrid DeprecationWarning in plot_example.py#482
Open
sohampatil01-svg wants to merge 2 commits intomllam:mainfrom
Open
fix: resolve xarray FacetGrid DeprecationWarning in plot_example.py#482sohampatil01-svg wants to merge 2 commits intomllam:mainfrom
sohampatil01-svg wants to merge 2 commits intomllam:mainfrom
Conversation
Collaborator
|
@sohampatil01-svg thanks, please create a corresponding issue, first. and also revert to the original PR template |
Author
"Hi @sadamov , thank you for the feedback! I have now created a corresponding issue for this bug (#485) and updated the PR description using the project's original template. Please let me know if any further changes are needed." |
Contributor
|
@sohampatil01-svg |
Author
|
"Thank you for the catch, @kshirajahere! I have now updated the PR body to include the missing sections and matched the exact formatting of the template. Please let me know if everything looks correct now." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes a
DeprecationWarningencountered during testing and plotting by replacing the deprecatedg.axesattribute withg.axson thexarray.plot.FacetGridobject inneural_lam/datastore/plot_example.py. This aligns the codebase with newer versions ofxarray(>= 2022.11) which match matplotlib'splt.subplotsstandard.No new dependencies are required.
Issue Link
closes #485
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee