Skip to content

fix: explicit cleanup of temporary directory in DummyDatastore#487

Open
sohampatil01-svg wants to merge 2 commits intomllam:mainfrom
sohampatil01-svg:fix/dummy-datastore-resource-warning
Open

fix: explicit cleanup of temporary directory in DummyDatastore#487
sohampatil01-svg wants to merge 2 commits intomllam:mainfrom
sohampatil01-svg:fix/dummy-datastore-resource-warning

Conversation

@sohampatil01-svg
Copy link
Copy Markdown

@sohampatil01-svg sohampatil01-svg commented Mar 21, 2026

Describe your changes

Adds a __del__ method to the DummyDatastore class to explicitly call cleanup() on its TemporaryDirectory object. This prevents ResourceWarning: Implicitly cleaning up <TemporaryDirectory ...> that currently litters the test output when the datastore objects are garbage collected.

No new dependencies are required.

Issue Link

closes #486

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug
    • maintenance: when your contribution is relates to repo maintenance, e.g. CI/CD or documentation

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • (if the PR is not just maintenance/bugfix) the PR is assigned to the next milestone. If it is not, propose it for a future milestone.
  • author has added an entry to the changelog (and designated the change as added, changed, fixed or maintenance)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@sadamov sadamov added the bug Something isn't working label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ResourceWarning: Implicitly cleaning up TemporaryDirectory in DummyDatastore

2 participants