Add type hints to improve readability in CustomMLFlowLogger#492
Closed
princekumarlahon wants to merge 1 commit intomllam:mainfrom
Closed
Add type hints to improve readability in CustomMLFlowLogger#492princekumarlahon wants to merge 1 commit intomllam:mainfrom
princekumarlahon wants to merge 1 commit intomllam:mainfrom
Conversation
Contributor
|
@princekumarlahon Hey this issue is already being solved in #455, please collaborate over there as duplicate PRs consumes extra time of maintainers :) |
Collaborator
|
See #455 |
Author
|
Thanks for the heads up! I noticed similar changes were already made in earlier PRs. I’ll take this as a learning experience and move on to another issue to contribute. Looking forward to contributing more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds type hints to the methods in
CustomMLFlowLoggerto make the code easier to read and understand.Type annotations have been added to the
__init__,save_dir, andlog_imagemethods based on their expected inputs and outputs.Issue Link
Closes #454
Type of change
Checklist before requesting a review
Checklist for reviewers
Author checklist after completed review
Checklist for assignee