Skip to content

Implementation for issue #445: Global forecasting support in test infrastructure#509

Closed
parth000007 wants to merge 5 commits intomllam:mainfrom
parth000007:main
Closed

Implementation for issue #445: Global forecasting support in test infrastructure#509
parth000007 wants to merge 5 commits intomllam:mainfrom
parth000007:main

Conversation

@parth000007
Copy link
Copy Markdown

Describe your changes

< Summary of the changes.>

< Please also include relevant motivation and context. >

< List any dependencies that are required for this change. >

Issue Link

< Link to the relevant issue or task, if applicable > (e.g. closes #00 or solves #00)

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug
    • maintenance: when your contribution is relates to repo maintenance, e.g. CI/CD or documentation

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • (if the PR is not just maintenance/bugfix) the PR is assigned to the next milestone. If it is not, propose it for a future milestone.
  • author has added an entry to the changelog (and designated the change as added, changed, fixed or maintenance)
  • Once the PR is ready to be merged, squash commits and merge the PR.

Claude AI and others added 2 commits March 23, 2026 14:57
Add GlobalDummyDatastore for testing global domains with all-zero boundary
masks. Relax test_boundary_mask to accept both regional (mixed 0/1) and
global (all-zero) boundary masks. Add test_training_global to verify
end-to-end training works correctly with global domains.

Closes mllam#445

Co-authored-by: Claude Sonnet 4.5

Co-authored-by: parth000007 <182992559+parth000007@users.noreply.github.com>
Agent-Logs-Url: https://github.com/parth000007/neural-lam/sessions/b4634aa9-5973-4fd6-9f86-ed17ac130e75
Add global forecasting support to test infrastructure
@parth000007
Copy link
Copy Markdown
Author

hi @joeloskarsson @SimonKamuk @leifdenby please review this PR and let me know the changes if required

@kshirajahere
Copy link
Copy Markdown
Contributor

I think this is being solved in #444

@parth000007
Copy link
Copy Markdown
Author

parth000007 commented Mar 24, 2026

I think this is being solved in #444

sorry i unable to saw that PR

@kshirajahere
Copy link
Copy Markdown
Contributor

its better to close this one and collaborate on tht

Claude AI and others added 3 commits March 24, 2026 10:37
…asses

Extract supporting components from ARModel to improve code organization:
- NormalizationManager: Handles state normalization and statistical buffers
- MetricTracker: Tracks validation and test metrics
- ModelVisualizer: Handles all plotting and visualization logic

Co-authored-by: parth000007 <182992559+parth000007@users.noreply.github.com>
Agent-Logs-Url: https://github.com/parth000007/neural-lam/sessions/28caac4a-33fa-499f-9856-aa3533dfc7b4
Extract NormalizationManager, MetricTracker, and ModelVisualizer from ARModel
to improve separation of concerns and code maintainability.

Before: ARModel was 779 lines handling 7+ responsibilities
After: ARModel is 649 lines (-17%) with 3 focused helper classes

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Co-authored-by: parth000007 <182992559+parth000007@users.noreply.github.com>
Agent-Logs-Url: https://github.com/parth000007/neural-lam/sessions/28caac4a-33fa-499f-9856-aa3533dfc7b4
…erarchy

Refactor model class hierarchy: extract helper classes from ARModel
@parth000007
Copy link
Copy Markdown
Author

its better to close this one and collaborate on tht

okay sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants