Fix: prevent custom edge_cmap from being overwritten in nx_draw_with_pos_and_attr (#93)#100
Open
Ashu-Rajput08 wants to merge 1 commit intomllam:mainfrom
Open
Fix: prevent custom edge_cmap from being overwritten in nx_draw_with_pos_and_attr (#93)#100Ashu-Rajput08 wants to merge 1 commit intomllam:mainfrom
Ashu-Rajput08 wants to merge 1 commit intomllam:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes an issue in nx_draw_with_pos_and_attr where a user-provided edge_cmap could be unintentionally overwritten by the default colormap.
The existing implementation checked for the key "cmap" in kwargs before assigning a default edge colormap, while the value being set was "edge_cmap". Since "cmap" corresponds to the node colormap parameter, this mismatch caused the condition to evaluate to True even when a custom edge_cmap was already provided. As a result, the user-defined edge colormap could be silently replaced.
This change updates the condition to check for "edge_cmap" instead of "cmap", ensuring that the default edge colormap is only applied when the user has not explicitly provided one.
No additional dependencies are required for this change.
Issue Link
Closes #93
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee