Skip to content

Fix KDTree node mapping order in connect_nodes_across_graphs(#82)#101

Open
Ashu-Rajput08 wants to merge 2 commits intomllam:mainfrom
Ashu-Rajput08:fix-kdtree-node-mapping-82
Open

Fix KDTree node mapping order in connect_nodes_across_graphs(#82)#101
Ashu-Rajput08 wants to merge 2 commits intomllam:mainfrom
Ashu-Rajput08:fix-kdtree-node-mapping-82

Conversation

@Ashu-Rajput08
Copy link
Copy Markdown

Describe your changes

This PR fixes a bug in connect_nodes_across_graphs where KDTree neighbour indices could be mapped to incorrect source nodes due to inconsistent node ordering.

Previously, the KDTree was constructed using the insertion order of G_source.nodes, while neighbour indices were later resolved using sorted(G_source.nodes). Since KDTree indices are positional, this mismatch could silently produce incorrect edge assignments when the insertion order differed from the sorted order.

The fix ensures that a single consistent source_nodes_list is used both when constructing the KDTree input (xy_source) and when mapping KDTree neighbour indices back to node labels.

Additionally, a regression test has been added that inserts nodes in a non-sorted order and verifies that the resulting edges match the expected nearest-neighbour mapping.

No new dependencies are required for this change.

Issue Link

Closes #82

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Wrong KDTree Node Mapping in connect_nodes_across_graphs

1 participant