Skip to content

Validate mesh node distance#102

Open
saitharun7 wants to merge 2 commits intomllam:mainfrom
saitharun7:validate-mesh-node-distance
Open

Validate mesh node distance#102
saitharun7 wants to merge 2 commits intomllam:mainfrom
saitharun7:validate-mesh-node-distance

Conversation

@saitharun7
Copy link
Copy Markdown

Describe your changes

< Summary of the changes.>

< Please also include relevant motivation and context. >

< List any dependencies that are required for this change. >

Issue Link

< Link to the relevant issue or task. > (e.g. closes #00 or solves #00)

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@saitharun7
Copy link
Copy Markdown
Author

This PR adds validation for mesh_node_distance in create_flat_singlescale_mesh_graph.

Previously, if mesh_node_distance was set to 0 or a negative value, the code would attempt to compute:

range_x / mesh_node_distance

This leads to a divide-by-zero warning and eventually an overflowerror when converting infinity to an integer.

Added a validation check:

if mesh_node_distance <= 0:
raise ValueError(
f"mesh_node_distance must be greater than 0, got {mesh_node_distance}"
)

This ensures invalid values are caught early with a clear error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant