Fix #93: Correct key check for custom edge_cmap in nx_draw_with_pos_a…#115
Open
Moka-4444 wants to merge 1 commit intomllam:mainfrom
Open
Fix #93: Correct key check for custom edge_cmap in nx_draw_with_pos_a…#115Moka-4444 wants to merge 1 commit intomllam:mainfrom
Moka-4444 wants to merge 1 commit intomllam:mainfrom
Conversation
…pos_and_attr Changed the key check from 'cmap' to 'edge_cmap' to prevent silently overwriting the user-provided edge_cmap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd_attr
Changed the key check from 'cmap' to 'edge_cmap' to prevent silently overwriting the user-provided edge_cmap.
Describe your changes
< Summary of the changes.>
< Please also include relevant motivation and context. >
< List any dependencies that are required for this change. >
Issue Link
< Link to the relevant issue or task. > (e.g.
closes #00orsolves #00)Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee