-
Notifications
You must be signed in to change notification settings - Fork 51
Fix README example and add test to run python-code example in CI #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leifdenby
merged 13 commits into
mllam:main
from
leifdenby:maint/readme-python-example-test
Sep 17, 2025
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
19d4933
add test to run python-code example in readme
leifdenby 61ba1ec
clearer docstring and types
leifdenby a770cfd
fix typo
leifdenby f5bcf27
changelog
leifdenby b84e22e
Merge branch 'main' into maint/readme-python-example-test
leifdenby 1d72dee
Merge branch 'main' of https://github.com/mllam/weather-model-graphs …
leifdenby 319145e
Merge branch 'maint/readme-python-example-test' of https://github.com…
leifdenby f1cffe2
update pre-commit action version
leifdenby c1620cf
fix mistake in readme caught by test :)
leifdenby afb7ecb
Merge branch 'main' of https://github.com/mllam/weather-model-graphs …
leifdenby bac1415
fix readme example and helping exception text
leifdenby a20c235
Merge branch 'main' of https://github.com/mllam/weather-model-graphs …
leifdenby cef4862
changelog
leifdenby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import re | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| def _parse_readme_examples(): | ||
| lines = open(Path(__file__).parent.parent / "README.md").read().splitlines() | ||
|
|
||
| # use regex to find all python code blocks | ||
| code_blocks = re.findall(r"```python(.*?)```", "\n".join(lines), re.DOTALL) | ||
|
|
||
| return code_blocks | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("codeblock_example", _parse_readme_examples()) | ||
| def test_readme_example(codeblock_example: str): | ||
| """ | ||
| Check that execution of the python code block in the README does not raise an exception. | ||
| """ | ||
| exec(codeblock_example) | ||
|
leifdenby marked this conversation as resolved.
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.