Open
Conversation
Member
|
Thanks for this! Something has gone wrong with the PR template. Can you fix that first please and then I will take a look at review this, thank you! |
Contributor
Author
|
Thanks for catching that! I’ve corrected the PR template formatting and updated the description. Please feel free to take another look, and let me know if there’s anything else I should improve. |
Contributor
Author
|
Hi, I’m planning to apply for GSoC with this organization and have started contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a test to verify that graphs saved using
wmg.save.to_pyg()conform to the graph-on-disk format expected by neural-lam.The test creates a sample graph using
wmg.create.archetype.create_oskarsson_hierarchical_graph, saves it to disk withwmg.save.to_pyg, and validates the output using the validator script from the neural-lam repository.If the validator script cannot be downloaded (for example due to network restrictions in CI), the test is skipped using
pytest.skipto avoid failing the test suite.No additional dependencies are required for this change.
Issue Link
Closes #88
Type of change
Checklist before requesting a review
Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
Checklist for assignee
Once the PR is ready to be merged, squash commits and merge the PR.