Skip to content

Validator test#94

Open
Shristi-Goel wants to merge 13 commits intomllam:mainfrom
Shristi-Goel:validator-test
Open

Validator test#94
Shristi-Goel wants to merge 13 commits intomllam:mainfrom
Shristi-Goel:validator-test

Conversation

@Shristi-Goel
Copy link
Copy Markdown
Contributor

@Shristi-Goel Shristi-Goel commented Mar 6, 2026

Describe your changes

This PR adds a test to verify that graphs saved using wmg.save.to_pyg() conform to the graph-on-disk format expected by neural-lam.

The test creates a sample graph using wmg.create.archetype.create_oskarsson_hierarchical_graph, saves it to disk with wmg.save.to_pyg, and validates the output using the validator script from the neural-lam repository.

If the validator script cannot be downloaded (for example due to network restrictions in CI), the test is skipped using pytest.skip to avoid failing the test suite.

No additional dependencies are required for this change.


Issue Link

Closes #88


Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form
  • I have requested a reviewer and an assignee

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section reflecting type of change:
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)

Once the PR is ready to be merged, squash commits and merge the PR.

@leifdenby
Copy link
Copy Markdown
Member

Thanks for this! Something has gone wrong with the PR template. Can you fix that first please and then I will take a look at review this, thank you!

@Shristi-Goel
Copy link
Copy Markdown
Contributor Author

Thanks for catching that! I’ve corrected the PR template formatting and updated the description. Please feel free to take another look, and let me know if there’s anything else I should improve.

@Shristi-Goel
Copy link
Copy Markdown
Contributor Author

Hi, I’m planning to apply for GSoC with this organization and have started contributing to the project.
I wanted to ask if there’s any proposal template, guidelines, or past proposals I could refer to while preparing mine.
It would really help me align my proposal with the project expectations. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strengthen test_save_to_pyg with output assertions and pytest.skip

2 participants