Skip to content

ci: update test matrix to Python 3.10-3.12, fix torch version#96

Open
Jayant-kernel wants to merge 1 commit intomllam:mainfrom
Jayant-kernel:fix/ci-python-version-matrix-issue-85
Open

ci: update test matrix to Python 3.10-3.12, fix torch version#96
Jayant-kernel wants to merge 1 commit intomllam:mainfrom
Jayant-kernel:fix/ci-python-version-matrix-issue-85

Conversation

@Jayant-kernel
Copy link
Copy Markdown

Fixes #85. The CI workflow was running on Python 3.8 despite pyproject.toml declaring requires-python >=3.10. Also updates the torch installation from the unsupported 1.8.1+cpu to 2.3.0+cpu and bumps actions/checkout and actions/setup-python to latest versions.

Describe your changes

The .github/workflows/ci-tests.yml workflow was configured to run on Python 3.8, which is not a supported interpreter per pyproject.toml (requires-python = ">=3.10"). This means CI was validating an unsupported Python version and potentially missing failures on supported ones.

Changes made:

  • Added a strategy.matrix to run tests on Python 3.10, 3.11, and 3.12
  • Updated torch installation from torch==1.8.1+cpu to torch==2.3.0+cpu (compatible with torch>=2.3.0 declared in optional deps)
  • Bumped actions/checkout from v2 to v4 and actions/setup-python from v2 to v5

No new dependencies required.

Issue Link

Closes #85

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form
  • I have requested a reviewer and an assignee

Fixes mllam#85. The CI workflow was running on Python 3.8 despite
pyproject.toml declaring requires-python >=3.10. Also updates
the torch installation from the unsupported 1.8.1+cpu to 2.3.0+cpu
and bumps actions/checkout and actions/setup-python to latest versions.
@Jayant-kernel
Copy link
Copy Markdown
Author

@leifdenby
Review my pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI version mismatch: pyproject requires >=3.10 but tests run on 3.8

1 participant