ci: update test matrix to Python 3.10-3.12, fix torch version#96
Open
Jayant-kernel wants to merge 1 commit intomllam:mainfrom
Open
ci: update test matrix to Python 3.10-3.12, fix torch version#96Jayant-kernel wants to merge 1 commit intomllam:mainfrom
Jayant-kernel wants to merge 1 commit intomllam:mainfrom
Conversation
Fixes mllam#85. The CI workflow was running on Python 3.8 despite pyproject.toml declaring requires-python >=3.10. Also updates the torch installation from the unsupported 1.8.1+cpu to 2.3.0+cpu and bumps actions/checkout and actions/setup-python to latest versions.
Author
|
@leifdenby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85. The CI workflow was running on Python 3.8 despite
pyproject.tomldeclaringrequires-python >=3.10. Also updates the torch installation from the unsupported1.8.1+cputo2.3.0+cpuand bumpsactions/checkoutandactions/setup-pythonto latest versions.Describe your changes
The
.github/workflows/ci-tests.ymlworkflow was configured to run on Python 3.8, which is not a supported interpreter perpyproject.toml(requires-python = ">=3.10"). This means CI was validating an unsupported Python version and potentially missing failures on supported ones.Changes made:
strategy.matrixto run tests on Python3.10,3.11, and3.12torch==1.8.1+cputotorch==2.3.0+cpu(compatible withtorch>=2.3.0declared in optional deps)actions/checkoutfromv2tov4andactions/setup-pythonfromv2tov5No new dependencies required.
Issue Link
Closes #85
Type of change
Checklist before requesting a review