Skip to content

Add equalizer feature #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

rohsahub
Copy link

Hello, I have added equalizer feature to cringraph (alt theme only), and fixed various things.

Changes summary:

  • Remove " from "IEF "Harman" Target.txt", allow windows to checkout this repository
  • Provide universal csv/tsv parser, remove data_format option
  • Open header links on new tab
  • Interpolate frequence responses to 1/48 octave, allow difference resolution files
  • Fix label display for show/hide graphs
  • Add extra features
    • Allow uploading frequence response file and target file
    • Parametric equalizer
      • Support generating EQ filters to selected target or other model automatically
      • Support exporting parametric eq file for DSP software like Peace
      • Support exporting graphic eq file for DSP software like Wavelet
    • Tone generator
  • Change default options in config.js
    • stickyLabels: true

Some features are already merged by MRS and Crinacle:

And this is my site:

It will be great if these feature can be merged to upstream, but I did lots of modification, if you are not sure the reason of some of the change please ask me.

@mlochbaum
Copy link
Owner

Thanks for working on this! I think I'll be able to merge, and possibly find a sensible solution for the old UI, but I probably won't have time to do anything for the next few days.

@SensmD
Copy link

SensmD commented Apr 16, 2022

1/48 file, I love it!

@rohsahub
Copy link
Author

Thanks for working on this! I think I'll be able to merge, and possibly find a sensible solution for the old UI, but I probably won't have time to do anything for the next few days.

Sure, please give me feedback if you have time! The traditional UI does need some work to support equalizer feature. And i just did a force pushed accidentally, only comments changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants