Merged
Conversation
Owner
|
Hey thanks for your contribution! I'm going to get to this I promise. I have very little time available right now. |
Owner
|
Hey, as we all know there is no good regex for emails. I think a better solution is to force mentions to start with @, since emails do not start with @ (adding ^ to the mention regex). I did not realize this before. |
Owner
|
Hey I reconsidered. I think is good to have a tag for emails, even if it does not catch every case, to avoid having emails marked as words. Thanks for your contribution, and sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have add a new regex rule to catch emails before mentions to avoid false positive.