Skip to content

fixing emails parse as mentions#118

Merged
mlomb merged 2 commits intomlomb:mainfrom
matteomorari:fixing-emails-parse-as-mentions
Mar 28, 2025
Merged

fixing emails parse as mentions#118
mlomb merged 2 commits intomlomb:mainfrom
matteomorari:fixing-emails-parse-as-mentions

Conversation

@matteomorari
Copy link
Contributor

I have add a new regex rule to catch emails before mentions to avoid false positive.

@mlomb
Copy link
Owner

mlomb commented Sep 26, 2024

Hey thanks for your contribution!

I'm going to get to this I promise. I have very little time available right now.

@mlomb
Copy link
Owner

mlomb commented Dec 21, 2024

Hey, as we all know there is no good regex for emails. I think a better solution is to force mentions to start with @, since emails do not start with @ (adding ^ to the mention regex). I did not realize this before.
Also if we add the tag email we should do something with it lol.

@mlomb mlomb added the pipeline Related to the pipeline label Dec 21, 2024
@mlomb
Copy link
Owner

mlomb commented Mar 28, 2025

Hey I reconsidered. I think is good to have a tag for emails, even if it does not catch every case, to avoid having emails marked as words.
I also force mentions to start with @ (nothing before), to disallow things like "abc@xyz" which are neither emails or mentions.

Thanks for your contribution, and sorry for the delay

@mlomb mlomb merged commit 75a77bc into mlomb:main Mar 28, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipeline Related to the pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants