Impl [Alerts history] Separate AlertView component for Projects-Alerts and Alerts-Tab 1.9.0
#3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AlertsTable. Updated the structure of Alerts and DetailsAlerts to make the code more readable and maintainable
ilan7empest
changed the title
ilan7empest
changed the title
1.9.0
Taras-Hlukhovetskyi
suggested changes
Mar 21, 2025
| @@ -51,7 +53,6 @@ const DetailsAlerts = () => { | |||
| const { | |||
| alerts, | |||
| handleRefreshAlerts, | |||
| paginatedAlerts, | |||
| paginationConfigAlertsRef, | |||
| requestErrorMessage, | |||
| refreshAlerts, | |||
There was a problem hiding this comment.
@pinis-gini-apps, @adi-gini , switching between model endpoints doesn't trigger new requests for alerts, the reason is that on details we use the pagination hook, we need to fix and separate logic in useAlertsPageData as well, so we don't have to use the pagination hook for alerts details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://iguazio.atlassian.net/browse/ML-9205?filter=-1