Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emscripten support #338

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Add emscripten support #338

merged 2 commits into from
Dec 14, 2023

Conversation

bytedream
Copy link
Contributor

@bytedream bytedream commented Dec 7, 2023

This PR adds general support for the *-emscripten target.

@bytedream bytedream marked this pull request as draft December 7, 2023 09:01
mlua-sys/Cargo.toml Outdated Show resolved Hide resolved
mlua-sys/src/lua51/compat.rs Outdated Show resolved Hide resolved
# Conflicts:
#	mlua-sys/src/lua51/lua.rs
#	mlua-sys/src/lua52/lua.rs
#	mlua-sys/src/lua53/lua.rs
#	mlua-sys/src/lua54/lua.rs
@bytedream bytedream marked this pull request as ready for review December 14, 2023 13:34
@bytedream
Copy link
Contributor Author

I merged the latest master (with a bit of force pushing to keep my commits clean)

@khvzak khvzak merged commit 0b9a85e into mlua-rs:master Dec 14, 2023
123 checks passed
@bytedream
Copy link
Contributor Author

bytedream commented Dec 14, 2023

@khvzak I just found another function signature mismatch that I accidentally removed when merging. The lua_sethook function in lua52 returns void but it actually must be a c_int.

I didn't want to create a PR for a one-line change, hence the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants