Repository navigation
feat: add settings editor mouse input - #40
Merged
Merged
Conversation
mm65x
commented
Aug 9, 2026
mm65x
left a comment
Owner
Author
There was a problem hiding this comment.
Review
No blocking findings.
Behavior
- Settings mouse events are routed before dashboard handling, so overlay input cannot leak into the dashboard.
- Visible rows use the same popup, content, and scroll geometry as rendering; section headers and outside clicks remain inert.
- Left clicks reuse the existing activation path for toggles, enum cycling, and text/numeric edit mode.
- Wheel events navigate and clamp at the first and last setting.
- Footer hit targets cover review, confirmation, cancellation, discard, and close flows.
- In-progress text edits are isolated from mouse navigation until Enter applies or Escape cancels them.
Verification
- Local format, all tests, clippy, release build, and diff checks pass.
- GitHub Format, Clippy, Linux, macOS, and Windows checks all pass.
- The focused tests cover visible rows, headers, scroll offsets, footer actions, and narrow boundaries.
Non-blocking follow-up
A future change could add full App-level event tests for each state transition; the current geometry/action tests plus the existing keyboard path are sufficient for this scoped change.
Merge recommendation
Ready after the draft is marked ready and an independent reviewer records approval. This account authored the PR, so GitHub will not allow it to self-approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #39