Differentiate OBJ_PIN and PTR_PIN. Add more pinning. Trace all global roots. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiate ptr pin and obj pin for hash maps
qinsoon
changed the title
udesou
reviewed
Feb 4, 2025
| @@ -66,7 +66,7 @@ JL_DLLEXPORT jl_typename_t *jl_new_typename_in(jl_sym_t *name, jl_module_t *modu | |||
| jl_typename_type); | |||
| // Typenames should be pinned since they are used as metadata, and are | |||
| // read during scan_object | |||
| PTR_PIN(tn); | |||
| OBJ_PIN(tn); | |||
There was a problem hiding this comment.
Should typenames be allocated in a non-moving space? Maybe add a FIXME comment saying that instead of pinning them, we might do that instead.
There was a problem hiding this comment.
I have a commit to add an allocation function jl_gc_alloc_non_moving_ and use it for cases like this. Do you want me to include the change in this PR? I planned to have it as a separate PR after this one, but I can include it here.
There was a problem hiding this comment.
This commit: qinsoon@70a4e14
|
|
||
| #define TRACE_GLOBALLY_ROOTED(r) add_node_to_roots_buffer(closure, buf, buf_len, r) | ||
|
|
||
| // This is a list of global variables that are marked with JL_GLOBALLY_ROOTED. We need to make sure that they |
There was a problem hiding this comment.
For now this is fine, but I wonder whether we should try to capture this automatically somehow. It's a bit of a pain that you had to add all these variables manually.
qinsoon
added a commit
to qinsoon/julia
that referenced
this pull request
Feb 6, 2025
… roots. (mmtk#84) This PR * differentiates `OBJ_PIN` from `PTR_PIN`. In rare cases, we have to deal with internal pointers, and have to use `PTR_PIN`. * pins more objects that cannot be moved. * traces all the `JL_GLOBALLY_ROOTED` symbols. This PR still transitively pins `jl_global_roots_list`. Without transitive pinning, we observed assertions failures in the precompilation step during Julia build, saying we reach objects without the valid object bit. This issue will be debugged and fixed after this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
OBJ_PINfromPTR_PIN. In rare cases, we have to deal with internal pointers, and have to usePTR_PIN.JL_GLOBALLY_ROOTEDsymbols.This PR still transitively pins
jl_global_roots_list. Without transitive pinning, we observed assertions failures in the precompilation step during Julia build, saying we reach objects without the valid object bit. This issue will be debugged and fixed after this PR.