Fix Clippy warnings for Rust 1.92 #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It warns "this assertion has a constant value". We replace the `cfg!` expression with the `#[cfg]` attribute.
The code acutally means making a tuple from the comma-separated `$($arg),*` expansion, but Clippy 1.92 mistook it as duplicated parenthesis in function calls. We make an explicit `let` binding for the arg tuple before passing it to the `call` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy warned "this assertion has a constant value" in a
debug_assert. We replaced thecfg!expression with the#[cfg]attribute.Clippy treated a tuple constructor as double parenthesis by mistake. We extracted the tuple constructor into an explicit let-binding.