Skip to content

Optimized chain loop #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mercuenomia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimized chain loop #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions jquery.json2html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
options.events = true;

//Make sure to take care of any chaining
return this.each(function(){
var thisLength = this.length
for( var i=0; i<thisLength; i++ ){

//let json2html core do it's magic
var result = json2html.transform(json, transform, options);
Expand All @@ -42,9 +43,9 @@
var dom = $(document.createElement('i')).html(result.html);

//Determine if we have events
for(var i = 0; i < result.events.length; i++) {
for(var j = 0; j < result.events.length; j++) {

var event = result.events[i];
var event = result.events[j];

//find the associated DOM object with this event
var obj = $(dom).find("[json2html-event-id-"+event.type+"='" + event.id + "']");
Expand All @@ -66,9 +67,11 @@
}

//Append it to the appropriate element
if (options.replace) $.fn.replaceWith.call($(this),$(dom).children());
else if (options.prepend) $.fn.prepend.call($(this),$(dom).children());
else $.fn.append.call($(this),$(dom).children());
});
if (options.replace) $.fn.replaceWith.call($(this[i]),$(dom).children());
else if (options.prepend) $.fn.prepend.call($(this[i]),$(dom).children());
else $.fn.append.call($(this[i]),$(dom).children());
}

return false
};
})(jQuery);