Skip to content

Fix Cannot use --format with --async error in async mode - #69

Merged
proksh merged 6 commits into
mainfrom
fix/async-flag-option
May 20, 2026
Merged

proksh merged 6 commits into
mainfrom
fix/async-flag-option

Conversation

@proksh

@proksh proksh commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • v3 hardcoded --format junit --output ... in run-cloud.sh, which the Maestro CLI rejects when combined with --async (CloudInteractor.kt:104).
  • Gate both flags on !MDEV_ASYNC so async runs no longer error. Sync mode is unchanged.

Test plan

  • bats tests/run-cloud.bats — 29/29 pass, including new test asserting --format/--output are omitted when MDEV_ASYNC=true.
  • run validate action

@proksh
proksh requested a review from Fishbowler May 19, 2026 13:46

@Fishbowler Fishbowler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

This includes a little bit of unnecessary noise from the loop, but let's clean that up at a later date.

@proksh
proksh merged commit b05ee68 into main May 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants