kernelversion: add package for checking kernel versions #205
+429
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
kernelversion
branch
from
36b7be3 to
559b0dc
Compare
This implementation comes from github.com/cyphar/filepath-securejoin's internal/kernelversion package. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
kernelversion
branch
from
559b0dc to
9d4b40e
Compare
kolyshkin
requested changes
Sep 15, 2025
| @@ -0,0 +1,13 @@ | |||
| // SPDX-License-Identifier: BSD-3-Clause | |||
| //go:build linux && go1.20 | |||
There was a problem hiding this comment.
Wonder why package doc requires go1.20 :)
| // same as GreaterEqualThan(KernelVersion{4, 0, 0, ..., 0, 0}), and that if the | ||
| // host kernel version is "4" then GreaterEqualThan(KernelVersion{4, 1}) will | ||
| // return false (because the host version will be treated as "4.0"). | ||
| func GreaterEqualThan(wantKver KernelVersion) (bool, error) { |
There was a problem hiding this comment.
Proper English would be something like "greater than or equal".
Or, we can use another name, say AtLeast. It will look like
if kernelversion.AtLeast(kernelversion.KernelVersion{4,2})which is still too much occurrences of "kernel" and "version", but otherwise ok.
Or, we can use a variadic function to simplify callers. Something like:
func AtLeast(want ...uint64)So the call can look simpler:
if kernelversion.AtLeast(2, 6, 19) {
...Or does it incur greater runtime overhead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation comes from github.com/cyphar/filepath-securejoin's
internal/kernelversion package.
Closes #204
Signed-off-by: Aleksa Sarai [email protected]