Remove a redundant overload. - #237
Merged
Celandriel merged 1 commit intoSep 4, 2026
Merged
Conversation
…t mod-playerbots was ported from originally, but we have a perfectly viable alternative that builds the packet identically. The logic is technically VERY slightly different, but the differences are on branches that never get executed in the code paths that the module actually uses.
airbreather
marked this pull request as ready for review
August 22, 2026 18:57
Celandriel
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the motivation for mod-playerbots/mod-playerbots#2692: once that other PR merges, there will be no more callers of this overload, and so these two files can return to their upstream-provided versions.