perf(endpoints): only allocate endpoint metadata when populated - #2
Closed
christianscott wants to merge 1 commit into
Closed
perf(endpoints): only allocate endpoint metadata when populated#2christianscott wants to merge 1 commit into
christianscott wants to merge 1 commit into
Conversation
CreateLBEndpoint allocated a Metadata proto and FilterMetadata map for every endpoint, only to nil them out when Istio auto-mTLS was off or the pod was not Istio-managed. Since this runs once per endpoint per backend and endpoint IR dominates control-plane heap at scale, return nil directly in the no-op cases. No wire-format change: the metadata was already nil after the empty check in those cases. Signed-off-by: Christian Scott <christian@modal.com>
Author
|
Reopened against upstream: kgateway-dev/kgateway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CreateLBEndpointallocated aMetadataproto andFilterMetadatamap for every endpoint, only to nil them out when Istio auto-mTLS was off or the pod was not Istio-managed. Since this runs once per endpoint per backend and endpoint IR dominates control-plane heap at scale (~60-67% of in-use heap in production profiles), return nil directly in the no-op cases.No wire-format change: metadata was already nil after the empty-map check in those cases.
Part 1 of a stack (split out of a larger endpoint-memory PR):
Change Type
/kind cleanup
Changelog
Additional Notes
Covered by a new unit test verifying metadata is nil unless auto-mTLS is enabled and the pod carries the Istio TLS mode label.