perf(endpoints): reuse precomputed endpoint hashes on derived collections - #7
Closed
christianscott wants to merge 1 commit into
Closed
perf(endpoints): reuse precomputed endpoint hashes on derived collections#7christianscott wants to merge 1 commit into
christianscott wants to merge 1 commit into
Conversation
…ions FinalBackendEndpoints and GatewayBackendClientCertificateVariantEndpoints cloned EndpointsForBackend by re-Adding every endpoint, which re-ran hashEndpoints -> HashProtoWithHasher (a full proto marshal) per endpoint per copy per recompute. Add ReuseEndpointsFrom, which copies the endpoint entries (cloned slices, no append aliasing) and reuses the precomputed epsEqualityHash, mixing in the copy's own upstreamHash for backend identity. The resulting equality hashes are byte-identical to the re-Add path, including the empty endpoint set (upstreamHash) and a non-empty set whose xor'd hash is zero (hash(0, upstreamHash)); emptiness is determined by endpoint count, not hash value. Benchmark: ~1088 B/endpoint copied -> ~16 B/endpoint, ~300x faster at 10k endpoints. Signed-off-by: Christian Scott <christian@modal.com>
Author
|
Reopened against kgateway-dev/kgateway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinalBackendEndpoints and GatewayBackendClientCertificateVariantEndpoints
cloned EndpointsForBackend by re-Adding every endpoint, which re-ran
hashEndpoints -> HashProtoWithHasher (a full proto marshal) per endpoint
per copy per recompute. Add ReuseEndpointsFrom, which copies the endpoint
entries (cloned slices, no append aliasing) and reuses the precomputed
epsEqualityHash, mixing in the copy's own upstreamHash for backend
identity. The resulting equality hashes are byte-identical to the re-Add
path, including the empty endpoint set (upstreamHash) and a non-empty set
whose xor'd hash is zero (hash(0, upstreamHash)); emptiness is determined
by endpoint count, not hash value.
Benchmark: ~1088 B/endpoint copied -> ~16 B/endpoint, ~300x faster at 10k
endpoints.
Signed-off-by: Christian Scott christian@modal.com
Stack created with GitHub Stacks CLI • Give Feedback 💬