perf(endpoints): drop the per-endpoint load-balancing-weight wrapper - #8
Closed
christianscott wants to merge 1 commit into
Closed
perf(endpoints): drop the per-endpoint load-balancing-weight wrapper#8christianscott wants to merge 1 commit into
christianscott wants to merge 1 commit into
Conversation
CreateLBEndpoint set LoadBalancingWeight to an explicit uint32 wrapper of value 1 for every endpoint. Envoy treats an unset per-endpoint weight as 1 (in all versions), so the wrapper was a heap allocation per endpoint with no behavioral effect; per-endpoint protos dominate control-plane heap at scale (~60-67% in profiles, with wrappers alone at ~8%). Locality-level LocalityLbEndpoints weights are computed exactly as before, treating an unset endpoint weight as 1 via a new lbWeight() helper. Plugins that set explicit endpoint weights (ServiceEntry, local cluster) are unaffected. Wire compatibility: omitting instead of explicitly sending weight 1 is behavior-identical for any Envoy version. Endpoint equality hashes change once, so envoys receive a single EDS re-push at upgrade (and again on rollback). Benchmarks (included): build path -9.5% B/op, -21% allocs/op at 100/1k/10k endpoints. Golden outputs regenerated: only per-endpoint loadBalancingWeight: 1 lines removed. Signed-off-by: Christian Scott <christian@modal.com>
Author
|
Reopened against kgateway-dev/kgateway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateLBEndpoint set LoadBalancingWeight to an explicit uint32 wrapper of
value 1 for every endpoint. Envoy treats an unset per-endpoint weight as
1 (in all versions), so the wrapper was a heap allocation per endpoint
with no behavioral effect; per-endpoint protos dominate control-plane
heap at scale (~60-67% in profiles, with wrappers alone at ~8%).
Locality-level LocalityLbEndpoints weights are computed exactly as
before, treating an unset endpoint weight as 1 via a new lbWeight()
helper. Plugins that set explicit endpoint weights (ServiceEntry, local
cluster) are unaffected.
Wire compatibility: omitting instead of explicitly sending weight 1 is
behavior-identical for any Envoy version. Endpoint equality hashes change
once, so envoys receive a single EDS re-push at upgrade (and again on
rollback).
Benchmarks (included): build path -9.5% B/op, -21% allocs/op at
100/1k/10k endpoints.
Golden outputs regenerated: only per-endpoint loadBalancingWeight: 1
lines removed.
Signed-off-by: Christian Scott christian@modal.com
Stack created with GitHub Stacks CLI • Give Feedback 💬