Add new optional flags for the cprover contracts library. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- --dfcc-debug-lib activates debug asserts in cprover_contracts.c - --dfcc-simple-invalid-pointer-model removes offset nondeterminism for invalid pointers produced in failure paths of the __CPROVER_is_fresh predicate. Mitigates some proof performance issues, but is possibly unsound due to reduced nondeterminism.
feliperodri
reviewed
Jan 23, 2025
| # | ||
| # Removes offset nondeterminism for invalid pointers created in failure paths | ||
| # of the __CPROVER_is_fresh predicate. Improves performance for some proofs. | ||
| # Unsound because of reduced nondeterminism. |
There was a problem hiding this comment.
Is there a way that we make this more clear to users? Maybe add unsound to the name of the flag? Does CBMC emit warnings when this flag is used? Is there a PR or GitHub issue link that we could add here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
DFCC_DEBUG_LIBin proof makefiles activates debug asserts in cprover_contracts.cDFCC_SIMPLE_INVALID_POINTER_MODELin proof makefiles removes offset nondeterminism for invalid pointers produced in failure paths of the__CPROVER_is_freshpredicate. Mitigates some proof performance issues, but is possibly unsound due to reduced nondeterminism.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.