Re-enable debug_assert in our standard library build #4207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original tests no longer fail when re-enabling debug assertions. Open tasks: - Figure out what change actually solved model-checking#1740 - Address the ICE we see in one test - Figure out why two other tests newly fail Resolves: model-checking#1740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original tests no longer fail when re-enabling debug assertions. Open tasks:
debug_assertis disabled in the standard library due to poor assertion messages #1740Resolves: #1740
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.