[WIP] Overwrite panic macros directly in libstd #4321
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-EndToEndBenchCI
|
Nice, thanks @bjorn3! We'll test this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant as an alternative to rust-lang/rust#145734 that also works for non-builtin macros. It currently doesn't work yet as
kani::paniccan't be referenced from libstd as it doesn't depend on kani. Presumably the definition of this function can be moved into the panic overwrite file. I'm not familiar enough with how everything is set up to actually do this though. If someone with more Kani experience can pick this PR up, that would be appreciated. If you don't like the approach I've taken (eg it is considered too hacky), feel free to close.