-
Notifications
You must be signed in to change notification settings - Fork 46
Subtree update automation: do not use git subtree merge --squash
#292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Have you tested this on your fork? This looks reasonable, but it'd be nice to have some testing before merging. |
Ack - I have tested this locally, but I will test once we have #290 merged and an updated toolchain in Kani. Putting this in draft mode for the time being. |
`git subtree merge --squash` will always reset the subtree to the state of the tree that is being merged from, which effectively eradicates all our local changes. This was just masked by merge conflicts arising as we were always attempted to merge from some long-ago version as we hadn't consistently kept "git-subtree-split" markers. This PR now amends the pull request descriptions to make sure we retain the necessary information and uses `git merge` instead of the subtree command.
a25edfb
to
24a1ae1
Compare
This is now ready for review. See https://github.com/tautschnig/verify-rust-std/actions/runs/14104094023 (creating PRs tautschnig#16 and tautschnig#17) and https://github.com/tautschnig/verify-rust-std/actions/runs/14104444534 (creating PR tautschnig#18 as a test that things also work fine when there is a pre-existing update PR for the subtree/library branch) for the logs of successful runs. |
I have now re-run this in my fork after updating my fork's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work debugging this! The 10,000 commits is unfortunate, but I don't have any better solutions, and since we squash and merge anyway the important thing is that the diff looks good (which it does).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
2d9d9fc
git subtree merge --squash
will always reset the subtree to the state of the tree that is being merged from, which effectively eradicates all our local changes. This was just masked by merge conflicts arising as we were always attempted to merge from some long-ago version as we hadn't consistently kept "git-subtree-split" markers.This PR now amends the pull request descriptions to make sure we retain the necessary information and uses
git merge
instead of the subtree command.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.