Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace package with deprecation notice #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace package with deprecation notice #15

wants to merge 2 commits into from

Conversation

jspahrsummers
Copy link
Member

@jspahrsummers jspahrsummers commented Jan 23, 2025 •
edited
Loading

To do

After merging

  • Release
  • Archive PyPI project
  • Archive GitHub repo

@jspahrsummers jspahrsummers requested a review from dsp-ant January 23, 2025 10:04
dsp-ant
dsp-ant requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not delete the code for now but just create a deprecation warning.

@jspahrsummers
Copy link
Member Author

Why is that? It exists in the version history.

@jspahrsummers jspahrsummers requested a review from dsp-ant January 27, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsp-ant dsp-ant Awaiting requested review from dsp-ant

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspahrsummers @dsp-ant