Remove incorrect acknowledgement from README of new Core package #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
stephentoub,
eiriktsarpalis,
mikekistler and
PederHP
halter73
changed the title
stephentoub
reviewed
Jun 3, 2025
stephentoub
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used copilot to help come up with the README for #428, but I did not review it carefully enough. I did run the sample code, but I didn't notice that we acknowledged a non-existant GitHub repo rather than mcpdotnet, initiated by Peder Holdgaard Pedersen as we should have. Since we already have this acknowledgement in the README for the primary package and we did not include this acknowledgement in the AspNetCore package, I decided to remove it. I did the same for the license notice since I think that's well covered by the README in the root of the repository.
However, I can add it back with the right acknowledgement and do the same for the AspNetCore package if we think that's better. These do show up on NuGet.org.