feat: support custom authorization headers, fix #395 #400
+48
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffhall
requested changes
May 15, 2025
cliffhall
added
enhancement
- Avoid calling .lowerCase twice - Keep 'Bearer ' prefix when header equals 'Authorization' - Remove unnecessary Array type checks
- Remove unnecessary auth header name check - Extract operations on headers into a function
|
Sorry to be jumping in a little late in the game, want to cc @pcarleton for extra 👀 . For anything auth-related I think we want to be careful that we're not introducing any unintentional inconsistencies here with security best practices, etc. that are being shared alongside the official docs + tools. I think for this ^^ PR it would be OK to merge with the caveat that we should follow up with some version of this feature, which would just make headers in general more flexible to add (including custom auth headers). |
cliffhall
requested changes
May 28, 2025
Express converts all header names to lowercase, which prevents custom headers with uppercase characters from being properly passed to the target service. This fix ensures that custom headers preserve their original capitalization when forwarded through the proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom header support.
Motivation and Context
See #395
How Has This Been Tested?
The header parser implementation has been tested with a server driven by Spring-AI locally.
Breaking Changes
This change will impact services that rely on the "Bearer " prefix for authentication.
Types of changes
Checklist