Set completion support to false by default #441
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Thanks for this fix. If I'm understanding the typescript SDK issue correctly, it seems like typescript servers are most likely not reporting completion correctly in their capabilities? Would it make sense to wait to merge this once that fix is out so we can test with the expected state using latest sdk versus a potentially buggy one? |
|
Yep, agreed, let's wait for a new TS SDK version to be published first with this fix. I'll have a quick look on other language SDK as well in the meantime. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change completion support default to false and use server capabilities value to assert support for completion.
Fixes #436
Motivation and Context
Current implementation always tries a first completion request on resource template or prompt usage, even if the server does not advertise support for completions. The silent error fallback currently implemented then switch back the support to false for further calls.
How Has This Been Tested?
Yes, with a server with completion, and with one without
Breaking Changes
None
Types of changes
Checklist
Additional context
I noticed server built using the Typescript SDK were not advertising completions support - even when they do support it - unless manually specified in the server construct arguments. I opened a PR to fix that as well to ensure completions capabilities advertising and use is more coherent. Same thing for Python SDK.