Skip to content

fix: Resource template query parameters not appended to request URI #450 #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dr3s
Copy link

@dr3s dr3s commented May 28, 2025

Trying to get Resource templates to work with query parameters

#450

Motivation and Context

UriTemplates for resources seem to not be fully implemented in inspector.

How Has This Been Tested?

Only manually tested

Breaking Changes

n/a

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [x ] I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@dr3s dr3s marked this pull request as ready for review May 28, 2025 14:25
@olaservo
Copy link
Member

olaservo commented Jun 1, 2025

Could you fix formatting by running this: npx prettier client/src/components/ResourcesTab.tsx --write

@olaservo
Copy link
Member

olaservo commented Jun 1, 2025

Testing with various Resource examples from here looks good so far: https://github.com/olaservo/mcp-misc/tree/main/example-resources

Could you add tests to cover some similar scenarios?

@olaservo olaservo added the waiting on submitter Waiting for the submitter to provide more info label Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on submitter Waiting for the submitter to provide more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants