Skip to content

refactor: improve CLI type safety and log level consistency #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

steviec
Copy link

@steviec steviec commented Jun 26, 2025

The CLI unnecessarily ignored some of the typescript SDK's types, which made it less type-safe and harder to maintain. The log levels were also hardcoded as strings instead of pulled from the types exposed by the SDK, which caused log levels to be inconsistent across the codebase.

Motivation and Context

I was working on a PR for a new CLI feature and noticed that a lot of the types were "any", which was a smell to me knowing that the typescript SDK uses strong typing. Instead of including this refactor in that PR, I thought it would be better to pull it out as a standalone PR.

How Has This Been Tested?

Tested locally using the CLI against my local MCP server, and all linting/testing run for the repo.

Breaking Changes

No, it should not affect anyone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None.

The CLI unnecessarily ignored some of the typescript SDK's
types, which made it less type-safe and harder to maintain.
The log levels were also hardcoded as strings instead of
pulled from the types exposed by the SDK, which caused
log levels to be inconsistent across the codebase.
@olaservo olaservo added the cli label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants