-
Notifications
You must be signed in to change notification settings - Fork 923
mcp: add icon + website for testing SEP-973 #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
mcp: add icon + website for testing SEP-973 #778
Conversation
|
Hi @jesselumarie! This looks cool. Just converted it to draft until the SEP is accepted and a Typescript SDK release contains the changes needed. |
|
It looks like some SDKs have already implemented this, and there's a related issue here: #861 (Edited) |
|
The holdup on icons being an array instead of a space-separated list in a string has been merged in the SDK and is in the latest release. @jesselumarie can you resolve the conflicts? |
718bd10 to
2e5bd02
Compare
2e5bd02 to
9dc3b74
Compare
|
@cliffhall just pushed up a resolved version 👍🏻 |
|
Currently seeing the following in browser devtools: That's owing to a change made to the Typescript SDK that aren't in your branch. With the latest version TS SDK temporarily added on my local copy of your branch, I see the icon display when I connect to the
I have a pending PR to fix the SDK version: #883 so it will soon be possible for you to merge main and fix this on your branch. |
| const { | ||
| connectionStatus, | ||
| serverCapabilities, | ||
| serverImplementation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




Motivation and Context
Adds a icon for the
simpleStreamableHttp.tsserver to test out SEP-973How Has This Been Tested?
Tested with the Figma MCP Server which has icons

Breaking Changes
n/a
Types of changes
Checklist