Skip to content

Conversation

@jesselumarie
Copy link

@jesselumarie jesselumarie commented Sep 4, 2025

Motivation and Context

Adds a icon for the simpleStreamableHttp.ts server to test out SEP-973

How Has This Been Tested?

Tested with the Figma MCP Server which has icons
image

Breaking Changes

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@jesselumarie jesselumarie changed the title mcp: add icon + website for testing SEP-974 mcp: add icon + website for testing SEP-973 Sep 4, 2025
@cliffhall cliffhall marked this pull request as draft September 4, 2025 20:06
@cliffhall cliffhall added the waiting on sdk Waiting for an SDK feature label Sep 4, 2025
@cliffhall
Copy link
Member

Hi @jesselumarie!

This looks cool. Just converted it to draft until the SEP is accepted and a Typescript SDK release contains the changes needed.

@cliffhall cliffhall marked this pull request as ready for review October 11, 2025 19:09
@olaservo
Copy link
Member

olaservo commented Oct 13, 2025

It looks like some SDKs have already implemented this, and there's a related issue here: #861

(Edited)

@cliffhall
Copy link
Member

The holdup on icons being an array instead of a space-separated list in a string has been merged in the SDK and is in the latest release.

@jesselumarie can you resolve the conflicts?

@jesselumarie jesselumarie force-pushed the jesselumarie/test-SEP-974 branch from 718bd10 to 2e5bd02 Compare October 19, 2025 02:32
@jesselumarie jesselumarie force-pushed the jesselumarie/test-SEP-974 branch from 2e5bd02 to 9dc3b74 Compare October 19, 2025 02:42
@jesselumarie
Copy link
Author

@cliffhall just pushed up a resolved version 👍🏻

@cliffhall
Copy link
Member

cliffhall commented Oct 21, 2025

Hi @jesselumarie

Currently seeing the following in browser devtools:
Screenshot 2025-10-21 at 1 45 09 PM

That's owing to a change made to the Typescript SDK that aren't in your branch.

With the latest version TS SDK temporarily added on my local copy of your branch, I see the icon display when I connect to the simpleStreamableHttp.ts server

Screenshot 2025-10-21 at 3 01 42 PM

I have a pending PR to fix the SDK version: #883 so it will soon be possible for you to merge main and fix this on your branch.

@cliffhall cliffhall added waiting on submitter Waiting for the submitter to provide more info and removed waiting on submitter Waiting for the submitter to provide more info labels Oct 21, 2025
const {
connectionStatus,
serverCapabilities,
serverImplementation,
Copy link
Member

@cliffhall cliffhall Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just call this serverInfo since it is that is what we're storing in this variable?

Screenshot 2025-10-21 at 3 09 24 PM Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on sdk Waiting for an SDK feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants