Skip to content

refactor(client): migrates CompletableFuture to reactive patterns for HttpClientSseClientTransport #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Aliaksie
Copy link
Contributor

@Aliaksie Aliaksie commented Apr 8, 2025

Replaced CompletableFuture with Mono from the reactive programming paradigm for the HttpClientSseClientTransport class internally, ensuring a consistent concurrency model using reactive patterns.

Motivation and Context

This change was made to align with a more consistent and modern concurrency implementation, avoiding the mixing of different paradigms. By switching from CompletableFuture to Mono, we improving maintainability and consistency, while also simplifying the concurrency handling for SSE event processing. This PR is related to issue

How Has This Been Tested?

Breaking Changes

No breaking changes should be introduced. The internal concurrency implementation has changed, but it does not affect the end users. No code or configuration updates are needed for consumers of the HttpClientSseClientTransport class.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

let me know if i missed something and need to add or if these changes don't make sense no problem just close this pr :-)

@Aliaksie Aliaksie force-pushed the issue115/httpClientSseClientTransport_internal branch from 9a72b0f to a34ca8b Compare April 9, 2025 15:48
@Aliaksie Aliaksie changed the title refactor: migrates CompletableFuture to reactive patterns for HttpClientSseClientTransport refactor(client): migrates CompletableFuture to reactive patterns for HttpClientSseClientTransport Apr 11, 2025
@chemicL chemicL self-assigned this Apr 14, 2025
@Aliaksie Aliaksie force-pushed the issue115/httpClientSseClientTransport_internal branch from d5b00c9 to 55c5310 Compare April 15, 2025 10:59
@Aliaksie Aliaksie force-pushed the issue115/httpClientSseClientTransport_internal branch from 55c5310 to fcd0d8f Compare April 16, 2025 15:36
@Aliaksie Aliaksie force-pushed the issue115/httpClientSseClientTransport_internal branch from fcd0d8f to f72e92b Compare April 21, 2025 11:49
@Aliaksie
Copy link
Contributor Author

maybe this PR should be some how incorporate into this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants