-
Notifications
You must be signed in to change notification settings - Fork 513
Support Progress Flow #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is really awesome pr! I really hope this one merged as soon as possible! |
Force-pushed with resolving conflict. |
BREAKING : Client Specification record is braking
Force-pushed with resolving conflict, again. |
@134130 thank you for trying to fill this missing capabilities. But because the progress tracking introduces a breaking changes to the existing API and goes beyond the tool calling, or server side only, I've updated the #298 issue, listing the required task to implement this capability. |
@@ -139,6 +139,16 @@ public Mono<McpSchema.ListRootsResult> listRoots(String cursor) { | |||
LIST_ROOTS_RESULT_TYPE_REF); | |||
} | |||
|
|||
public Mono<Void> notification(String method, Object params) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too generic. We would need something like progress(ProgressNotificaiton pn)
instead.
Motivation and Context
How Has This Been Tested?
HttpServletSseServerTransportProviderIntegrationTests#testProgressNotification
Breaking Changes
Types of changes
Checklist
Additional context