Improved Trio support #946
Conversation
* Removed the asyncio-only parametrization of the anyio_backend except for test_ws, as `websockets` doesn't support Trio yet * Try to close async generators explicitly where possible * Changed nesting order for more predictable closing of async resources * Refactored `__aenter__` and `__aexit__` in some cases to exit the task group if there's a problem during initialization * Fixed test failures in client/test_auth.py where an async fixture was used in sync tests * Fixed subtle bug in `SimpleEventStore` where retrieving the stream ID was timing-dependent
| # This is to avoid test failures on Trio due to httpx's failure to explicitly close | ||
| # async generators | ||
| "ignore::pytest.PytestUnraisableExceptionWarning" |
There was a problem hiding this comment.
Can we solve those? Why this doesn't happen on asyncio?
There was a problem hiding this comment.
Trio considers implicit async generator finalization a bad practice and emits a warning. Pytest turns this into an unraisable exception warning.
There was a problem hiding this comment.
The only way to fix this is to fix the problem in httpcore.
There was a problem hiding this comment.
How would the fix in httpcore look like?
There was a problem hiding this comment.
Ah, this is not resource warning anyway, I'm okay with it. I read it wrongly.
There was a problem hiding this comment.
I could just make a PR against httpcore if you're willing to review it.
There was a problem hiding this comment.
It looks like it needs changes in httpx as well. I'll know the full picture once I have the tests passing locally.
websocketsdoesn't support Trio yet__aenter__and__aexit__in some cases to exit the task group if there's a problem during initializationSimpleEventStorewhere retrieving the stream ID was timing-dependenttyping-extensionsto dependencies, as the code already imported it unconditionallyMotivation and Context
This was requested at https://github.com/anthropics/oss-collab/issues/60.
How Has This Been Tested?
No.
Breaking Changes
No.
Types of changes
Checklist
Additional context