create rmcp-core crate to isolate implementations from traits and core logic. (step 1) #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hendler
force-pushed
the
hendler/core-lib-refactor
branch
3 times, most recently
from
79576a2 to
3cefc7a
Compare
Hendler
force-pushed
the
hendler/core-lib-refactor
branch
from
3cefc7a to
b4d07f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#95 (comment)
How Has This Been Tested?
All tests pass
Breaking Changes
Users of the low level library may need to change imports in their implementation or use different feature flags to build.
Types of changes
Checklist
Additional context
Draft PR to aid in discussion