-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add Sequential Thinking tests and update TypeScript SDK versions #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sequential Thinking tests and update TypeScript SDK versions #2850
Conversation
| "@types/jest": "^29.5.14", | ||
| "@types/node": "^22", | ||
| "@types/yargs": "^17.0.32", | ||
| "jest": "^29.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think elsewhere we're migrating jest -> vitest. I think vitest works a lot better with TypeScript and is largely a drop-in replacement - possibly we should use that here instead?
(I've also used it in a bunch of other projects and really liked it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like vitest vs jest as well. The PR in the Typescript repo shows how easy it is to migrate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Since I just used the same test framework as other servers here and they also need to be converted, I'll just merge this PR as-is and convert all tests in one go separately: #2882
(This PR was a prerequisite to a couple other followup PRs already, so I'd prefer to have it merged sooner rather than later and unblock those, too.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes here: #2884
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think elsewhere we're migrating jest -> vitest. I think vitest works a lot better with TypeScript and is largely a drop-in replacement - possibly we should use that here instead?
(I've also used it in a bunch of other projects and really liked it)
Fully support this!
Description
Adds support for automated tests for Sequential Thinking and updates SDK versions.
Server Details
Motivation and Context
There were no automated tests for Sequential Thinking yet, and SDK versions were behind.
How Has This Been Tested?
Only automated tests so far.
Breaking Changes
None
Types of changes
Checklist