Skip to content

README Fix #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

README Fix #161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b71310
Add missing inputSchema object properties for tools listing.
samkudr Sep 8, 2025
0e2b198
Fix service: remove unprotocoled shutdown() func, use the designed fu…
samkudr Sep 8, 2025
92b499e
Make successfully finished mcpService to gracefully shutdown its group.
samkudr Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ await server.withMethodHandler(ListTools.self) { _ in
name: "weather",
description: "Get current weather for a location",
inputSchema: .object([
"type": .string("object"),
"properties": .object([
"location": .string("City name or coordinates"),
"units": .string("Units of measurement, e.g., metric, imperial")
Expand All @@ -444,6 +445,7 @@ await server.withMethodHandler(ListTools.self) { _ in
name: "calculator",
description: "Perform calculations",
inputSchema: .object([
"type": .string("object"),
"properties": .object([
"expression": .string("Mathematical expression to evaluate")
])
Expand Down Expand Up @@ -692,13 +694,8 @@ struct MCPService: Service {
// Start the server
try await server.start(transport: transport)

// Keep running until external cancellation
try await Task.sleep(for: .days(365 * 100)) // Effectively forever
}

func shutdown() async throws {
// Gracefully shutdown the server
await server.stop()
// Keep running until external cancellation or receiving EOF
await server.waitUntilCompleted()
}
}
```
Expand Down Expand Up @@ -738,17 +735,20 @@ await server.withMethodHandler(CallTool.self) { params in

// Create MCP service and other services
let transport = StdioTransport(logger: logger)

let mcpService = MCPService(server: server, transport: transport)
// use .gracefullyShutdownGroup instead of the default .cancelGroup, because group cancellation leads to ServiceGroupError.serviceFinishedUnexpectedly when mcpService receives, for example, EOF, which is a normal signal to shutdown
let mcpServiceCfg = ServiceGroupConfiguration.ServiceConfiguration(service: mcpService, successTerminationBehavior: .gracefullyShutdownGroup)

let databaseService = DatabaseService() // Your other services
let databaseServiceCfg = ServiceGroupConfiguration.ServiceConfiguration(service: databaseService)

// Create service group with signal handling
let serviceGroup = ServiceGroup(
services: [mcpService, databaseService],
configuration: .init(
gracefulShutdownSignals: [.sigterm, .sigint]
),
logger: logger
)
let serviceGroupCfg = ServiceGroupConfiguration(
services: [mcpServiceCfg, databaseServiceCfg],
gracefulShutdownSignals: [.sigterm, .sigint],
logger: logger)
let serviceGroup = ServiceGroup(configuration: serviceGroupCfg)

// Run the service group - this blocks until shutdown
try await serviceGroup.run()
Expand All @@ -760,8 +760,6 @@ This approach has several benefits:
Automatically traps SIGINT, SIGTERM and triggers graceful shutdown
- **Graceful shutdown**:
Properly shuts down your MCP server and other services
- **Timeout-based shutdown**:
Configurable shutdown timeouts to prevent hanging processes
- **Advanced service management**:
[`ServiceLifecycle`](https://swiftpackageindex.com/swift-server/swift-service-lifecycle/documentation/servicelifecycle)
also supports service dependencies, conditional services,
Expand Down