Make parameter propagation in SingularTransformer final #4642
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
added
the
L: Electrical.Analog
|
@AHaumer, could you please add a suitable second reviewer? |
|
The final-change is good in itself. But I don't see how there would be a index reduction failure without the change, as that would imply that non-literal parameter bindings are assumed to be modifiable after translation - which seems kind of odd to me. |
AHaumer
approved these changes
May 13, 2025
There was a problem hiding this comment.
Since the test case is constructed that way that L1=L2=M=L adding final to the parameter propagation makes sense and does no harm. Anyway, this examples is part of ModelicaTest, not MSL.
@henrikt-ma you have to invite at least a second reviewer, could be @HansOlsson @casella @christiankral @dietmarw .
HansOlsson
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refining the logic for parameter evaluation in System Modeler, we encountered the need to see that these parameter propagations are final.
Without it, there is a differential equation with parametric coefficients that causes incomplete index reduction since the coefficients are zero for the given parameter values.
The change is similar to #4407, where the conversation shows that making parameter propagation final isn't a controversial change.