-
Notifications
You must be signed in to change notification settings - Fork 174
Resolves the problems with zero system (#4654) #4656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shall also add a link to Modelica.Magnetic.FundamentalWave.UsersGuide.ZeroSystem in the documentation of the zero impedance models.
Modelica/Electrical/Machines/BasicMachines/Components/ZeroImpedance.mo
Outdated
Show resolved
Hide resolved
Modelica/Electrical/Machines/Interfaces/PartialBasicInductionMachine.mo
Outdated
Show resolved
Hide resolved
Modelica/Magnetic/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding.mo
Outdated
Show resolved
Hide resolved
@christiankral I followed your suggestions, but the description of the Boolean parameter should rather be: |
Good point. |
quick comment: is there a good reason to call the new model ZeroImpedance when the previous (somewhat related) was called ZeroInductor? I do understand that there's a bit of difference between the two. |
First: everything is 100% backwards compatible. |
@AHaumer according to Modelica.UsersGuide.Conventions.ModelicaCode.Format, we should have something like Boolean useZeroSystem=true "= true if zero current is explicitly computed"; |
Now I've corrected descriptions string of useZeroSystem according to Conventions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but might add annotation(Evaluate=true);
to the parameter as it normally should be evaluated.
Modelica/Electrical/Machines/BasicMachines/Components/ZeroImpedance.mo
Outdated
Show resolved
Hide resolved
…dance.mo Co-authored-by: Henrik Tidefelt <[email protected]>
Co-authored-by: Henrik Tidefelt <[email protected]>
Implementing a Boolean parameter useZeroSystem to be able to suppress the calculation of the zero current (set to zero).
Backwards compatible: Default = true. In 3 examples (Modelica.Electrical.Machines.Examples.InductionMachines.IMC_YD, Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_YD, Modelica.QuasiStatic.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_YD) used to resolve numerical issues as reported in #4654 and #4486. Setting the attribute nominal = 10 (#4486) has been removed again.
Should we backport this to maintenance/4.1.0 ?