feat(tui): adapt config list table layout - #18
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a width-aware configuration list table (_build_config_list_table) in the CLI slash handlers to dynamically adapt the TUI rendering of writable config fields based on the terminal width. It also adds corresponding unit tests to verify the layout behavior across compact, medium, and full widths. The review feedback highlights two important issues: first, the _shorten helper incorrectly treats falsy values like 0 or False as empty strings, which should be resolved by explicitly checking for None; second, the _config_reload_text helper incorrectly treats the hot_reload field as a boolean, which fails to preserve string values like 'partial' and should be updated to handle both booleans and strings properly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Features & Enhancements
_build_config_list_tablein CLI slash handlers to dynamically adapt the TUI layout of writable config fields based on terminal width.Bug Fixes (Address Review Feedback)
_shorten: Fixed the helper to explicitly check forNoneso that falsy values like0orFalseare no longer incorrectly treated as empty strings._config_reload_text: Updated the helper to correctly process both boolean and string values (e.g.,'partial') for thehot_reloadfield instead of strictly casting it to a boolean.