Skip to content

Conversation

@suluyana
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @suluyana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement for Anthropic LLMs by enabling the exposure of their internal 'thinking' process during generation. The core change involves modifying the API call parameters to activate this thinking mode and updating the streaming message processing to correctly capture and expose this reasoning content separately from the main output. This aims to provide greater transparency into the model's decision-making and problem-solving steps.

Highlights

  • Anthropic Thinking Feature: Implemented support for Anthropic's 'thinking' capability, allowing the model to generate internal reasoning steps that can be streamed and captured.
  • Streaming Thinking Content: Enhanced the streaming output handler to differentiate and capture 'thinking_delta' content, storing it in a new reasoning_content field within the message object.
  • Configuration for Thinking: Introduced enable_thinking and thinking_budget parameters, accessible via extra_body, to control the activation and token allocation for the thinking feature in Anthropic API calls.
  • Test Coverage: Added a new test case (test_stream_agent_multi_round_with_thinking) to validate the functionality of streaming thinking content, including assertions for the presence of reasoning_content.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Anthropic's "thinking" feature, which enables streaming of intermediate reasoning steps from the model. The implementation correctly handles new streaming events and populates the reasoning_content in the Message object. The tests are also updated to cover this new functionality. I have a few suggestions for improvement, including preventing unnecessary data from being sent to the Anthropic API, a note of caution about a significant increase in the default max_tokens, and a comment on reduced test coverage from a removed test. Overall, this is a valuable feature addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant