Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Webdriver launcher to setViewportPlugin #2850

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/many-scissors-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@web/test-runner-webdriver': minor
'@web/test-runner-commands': minor
---

Add support for Webdriver launcher to setViewportPlugin
142 changes: 68 additions & 74 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions packages/test-runner-commands/src/setViewportPlugin.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { TestRunnerPlugin } from '@web/test-runner-core';
import type { ChromeLauncher } from '@web/test-runner-chrome';
import type { PlaywrightLauncher } from '@web/test-runner-playwright';
import type { WebdriverLauncher } from '@web/test-runner-webdriver';

export interface Viewport {
width: number;
Expand Down Expand Up @@ -50,6 +51,12 @@ export function setViewportPlugin(): TestRunnerPlugin {
return true;
}

if (session.browser.type === 'webdriver') {
const browser = session.browser as WebdriverLauncher;
await browser.setWindowSize(session.id, payload.width, payload.height);
return true;
}

throw new Error(
`Setting viewport is not supported for browser type ${session.browser.type}.`,
);
Expand Down
7 changes: 7 additions & 0 deletions packages/test-runner-webdriver/src/IFrameManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,13 @@ export class IFrameManager {
return this.driver.keys(keys);
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
async setWindowSize(_: string, _width: number, _height: number) {
throw new Error(
'Unsupported operation. In order to set window size in Webdriver, set "concurrency" to 1.',
);
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
async performActions(_: string, _actions: object[]) {
throw new Error(
Expand Down
4 changes: 4 additions & 0 deletions packages/test-runner-webdriver/src/SessionManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ export class SessionManager {
return { testCoverage: this.config.coverage ? testCoverage : undefined };
}

async setWindowSize(_: string, width: number, height: number) {
return this.driver.setWindowSize(width, height);
}

async performActions(_: string, actions: object[]) {
return this.driver.performActions(actions);
}
Expand Down
7 changes: 7 additions & 0 deletions packages/test-runner-webdriver/src/webdriverLauncher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,13 @@ export class WebdriverLauncher implements BrowserLauncher {
return this.driverManager.sendKeys(sessionId, keys);
}

setWindowSize(sessionId: string, width: number, height: number) {
if (!this.driverManager) {
throw new Error('Not initialized');
}
return this.driverManager.setWindowSize(sessionId, width, height);
}

takeScreenshot(sessionId: string, locator: string) {
if (!this.driverManager) {
throw new Error('Not initialized');
Expand Down
Loading