[BUG]: Replies sometimes include the command in the mod-facing thread messages

[kezz]

Bot Version

4.1.2

How are you hosting Modmail?

Other

Error Logs

https://hastebin.cc/nedawotefa

Screenshots

Additional Information

Seems to only occur when using links and also only shows up on the moderator side.

[lorenzo132]

Hi,
I cant seem to be able to reproduce this specific bug.

When did you start to notice this issue?

Sidenote: I will soon release a new version of modmail to Github, with a few bugfixes and new feature.
Once that has happened, could u test if it still happens?

[martinbndr]

So I may just also noticed this issue aswell, it occurs on the latest version but not always, on certain cases.

@commands.command()
@checks.has_permissions(PermissionLevel.SUPPORTER)
@checks.thread_only()
async def reply(self, ctx, *, msg: str = ""):
      """
      Reply to a Modmail thread.

      Supports attachments and images as well as
      automatically embedding image URLs.
      """

      ctx.message.content = msg

      async with ctx.typing():
          await ctx.thread.reply(ctx.message)

(Same for areply etc)

As per code the message.content info gets overwritten to be just the message provided via the command. This could be the issue that it sometimes does not fully get overwritten and then message.content as the original command message is used
But wondering why it just occurs only sometimes.

[sebkuip]

Another possible case is that we've had it happen to ourselves just now, but it seems to happen specifically with aliases to reply. So another option is that alias handling causes this issue.

[StephenDaDev]

I believe this is alias related. If I remember correctly, there was a change to alias handling back in early 2020 that I thought had resolved this. I'm not sure if this is continued or if some other change in the past 5 years brought it back

[StephenDaDev]

Canrepro, 4.2.0

[lorenzo132]

Canrepro, 4.2.0

Can you check that this still happens in #3391 ?

[StephenDaDev]

This continues to occur occasionally in v4.2.0.

For public documentation, we have discussed this with our team and believe it is a race condition issue that only occurs at certain times. We have another attempted fix in #3392 which we believe will resolve this and are working as fast as possible to test and merge it to main. We appreciate the patience while we have worked on this.

[lorenzo132]

This continues to occur occasionally in v4.2.0.

For public documentation, we have discussed this with our team and believe it is a race condition issue that only occurs at certain times. We have another attempted fix in #3392 which we believe will resolve this and are working as fast as possible to test and merge it to main. We appreciate the patience while we have worked on this.

For clarification, this is confirmed fixed in #3392