Fix MagicPreview errors when extra is not installed #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where VersionX generates frequent error messages in MODX logs when the MagicPreview extra is not installed.
Problem
When MagicPreview is not installed, VersionX was attempting to load the MagicPreview service without first checking if the required path exists, causing MODX to log errors:
Solution
Added
file_exists()
checks before attempting to load the MagicPreview service in two locations:VersionX::magicPreviewLoaded()
method - Added path existence check before callinggetService()
Changes
Impact
The fix is minimal and surgical, adding only the necessary path checks to prevent error logging while preserving all existing functionality.
Fixes #150.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.